JS - reset correctly radio buttons #13055
Conversation
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d90e41729acaeb8/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://3.101.106.178:8877/57d1b99accf92ff/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/d90e41729acaeb8/output.txt Total script time: 24.08 mins
Image differences available at: http://54.67.70.0:8877/d90e41729acaeb8/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/57d1b99accf92ff/output.txt Total script time: 29.33 mins
Image differences available at: http://3.101.106.178:8877/57d1b99accf92ff/reftest-analyzer.html#web=eq.log |
|
It looks like there is a regression in some checkbox reference tests. I can only guess that this has something to do with the |
If that's the case, perhaps this comment applies here as well (meaning that we'd need to somehow fix/update the code in pdf.js/src/display/annotation_layer.js Lines 636 to 638 in 709c57a |
I replaced |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8bac9b3bdae8496/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/530cab1a43f0715/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/8bac9b3bdae8496/output.txt Total script time: 25.51 mins
Image differences available at: http://54.67.70.0:8877/8bac9b3bdae8496/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/530cab1a43f0715/output.txt Total script time: 30.89 mins
Image differences available at: http://3.101.106.178:8877/530cab1a43f0715/reftest-analyzer.html#web=eq.log |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/84bd6f4e00d14f6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://3.101.106.178:8877/9af476bc30724be/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/84bd6f4e00d14f6/output.txt Total script time: 23.97 mins
Image differences available at: http://54.67.70.0:8877/84bd6f4e00d14f6/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/9af476bc30724be/output.txt Total script time: 29.68 mins
Image differences available at: http://3.101.106.178:8877/9af476bc30724be/reftest-analyzer.html#web=eq.log |
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/365e7e6047e4bf6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 1 Live output at: http://3.101.106.178:8877/dddd1b24a11cdde/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/365e7e6047e4bf6/output.txt Total script time: 3.25 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/dddd1b24a11cdde/output.txt Total script time: 5.07 mins
|
|
Thanks! |
…zeAnnotationLayer`
Currently errors occuring within the `src/display/{text_layer, annotation_layer}.js` files are not being handled properly by the test-suite, and the tests simply time out rather than failing as intended.
This makes it *very* easy to accidentally overlook a certain type of errors, see e.g. mozilla#13055 (comment), which this patch will thus improve.
…zeAnnotationLayer`
Currently errors occurring within the `src/display/{text_layer, annotation_layer}.js` files are not being handled properly by the test-suite, and the tests simply time out rather than failing as intended.
This makes it *very* easy to accidentally overlook a certain type of errors, see e.g. mozilla#13055 (comment), which this patch will thus prevent.
No description provided.